feat(githubCorner): add width and height attributes#1992
Open
dpschen wants to merge 2 commits intodocsifyjs:developfrom
Open
feat(githubCorner): add width and height attributes#1992dpschen wants to merge 2 commits intodocsifyjs:developfrom
dpschen wants to merge 2 commits intodocsifyjs:developfrom
Conversation
Add width and height attribute. This fixes jumping of the SVG for loading for slow connections.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 43e3109:
|
Koooooo-7
added
the
ui/ux
Member
|
Tests are not running for some reason. |
Member
|
Changing bases to main and back to develop fixed it (same issue I've had in other projects, changing base always works). |
trusktr
approved these changes
Jul 9, 2023
Member
|
This will conflict with We'll merge that one first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add width and height attribute.
This fixes jumping of the SVG for loading for slow connections.
Here is a video showing this behavior for the zod documentation:
Screen.Recording.2023-02-17.at.14.55.08.mp4
This adds width and height attributes to the github corner svg so that the intrinsic size is defined. See also https://web.dev/optimize-cls/#modern-best-practice. This does not prevent overwriting the size via CSS later so it shouldn't break any user CSS.
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
Tested in the following browsers: