Skip to content

add an option to render the navbar when onlyCover is true#1706

Open
trusktr wants to merge 2 commits intodevelopfrom
onlyCoverNavbar-option
Open

add an option to render the navbar when onlyCover is true#1706
trusktr wants to merge 2 commits intodevelopfrom
onlyCoverNavbar-option

Conversation

@trusktr
Copy link
Member

@trusktr trusktr commented Dec 31, 2021

Summary

add an option to render the navbar when onlyCover is true

What kind of change does this PR introduce?

Feature

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Related issue, if any:

fixes #1696

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Dec 31, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/BCJ5sQJfwakGi1VCapq32HDvKK4P
✅ Preview: https://docsify-preview-git-onlycovernavbar-option-docsify-core.vercel.app

@trusktr trusktr mentioned this pull request Dec 31, 2021
Closed
1 task
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 31, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 43a1bfe:

Sandbox Source
docsify-template Configuration
nice-zhukovsky-m3jl7 Issue #1696
nice-dust-9ytri Issue #1696

@trusktr
Copy link
Member Author

trusktr commented Dec 31, 2021

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

mag Inspect: https://vercel.com/docsify-core/docsify-preview/5pGhPTDoqteu2Z5vcCXaqKtZkkvy white_check_mark Preview: https://docsify-preview-git-onlycovernavbar-option-docsify-core.vercel.app

It would be awesome if we could somehow specify Docsify options to use for the vercel previews, and have two previews: one set to preview the actual docs site works fine, and one set to preview config/feature changes.

@trusktr trusktr marked this pull request as ready for review January 29, 2022 04:42
@trusktr trusktr marked this pull request as draft January 29, 2022 04:47
@trusktr trusktr marked this pull request as ready for review January 29, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing navbar with only coverpage

1 participant

@trusktr