Skip to content

test: for making test steady in docker locally.#1688

Merged
trusktr merged 7 commits intodevelopfrom
docker-local
Jan 4, 2022
Merged

test: for making test steady in docker locally.#1688
trusktr merged 7 commits intodevelopfrom
docker-local

Conversation

@Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Dec 9, 2021 •
edited
Loading

Summary

For test locally, add docker options.

What kind of change does this PR introduce?

Test

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Dec 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/GzcWzaMSTrPjgg2MwN1fUfkcGgFB
✅ Preview: https://docsify-preview-git-docker-local-docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 9, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa91d9e:

Sandbox Source
docsify-template Configuration

@trusktr trusktr marked this pull request as ready for review January 4, 2022 06:10
@trusktr
Copy link
Member

trusktr commented Jan 4, 2022

Looks good. This doesn't affect anything else, and allows people an alternative way to run tests locally. Let's merge it.

@trusktr
Copy link
Member

trusktr commented Jan 4, 2022

All checks passed after a re-run. Let's fix those pesky flaky tests.

@trusktr trusktr requested a review from a team January 4, 2022 06:17
@trusktr
Copy link
Member

trusktr commented Jan 4, 2022

As these added package.json scripts are harmless and do not affect any other processes, I will merge. I've been unable to run tests locally for way too long.

@trusktr trusktr merged commit 5cac06d into develop Jan 4, 2022
@trusktr trusktr deleted the docker-local branch January 4, 2022 06:18
@sy-records
Copy link
Member

sy-records commented Jan 4, 2022

This should be merged with squash

@Koooooo-7 Koooooo-7 mentioned this pull request Jan 6, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2022
Merged
@easy-quest easy-quest mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trusktr trusktr trusktr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koooooo-7 @trusktr @sy-records