Skip to content

docs: update formatUpdated#1645

Merged
Koooooo-7 merged 2 commits intodevelopfrom
fix-format-date
Oct 6, 2021
Merged

docs: update formatUpdated#1645
Koooooo-7 merged 2 commits intodevelopfrom
fix-format-date

Conversation

@Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Oct 4, 2021 •
edited
Loading

Summary

Add the config formatUpdated: '{YYYY}/{MM}/{DD} {HH}:{mm}' in docs to make this plugin more clearly.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel
Copy link

vercel bot commented Oct 4, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/GPguTCxahS9K4eE7F9X55jdNVit6
✅ Preview: https://docsify-preview-git-fix-format-date-docsify-core.vercel.app

@Koooooo-7 Koooooo-7 marked this pull request as draft October 4, 2021 13:44
@Koooooo-7 Koooooo-7 marked this pull request as ready for review October 4, 2021 13:55
@trusktr
Copy link
Member

trusktr commented Oct 4, 2021

It doesn't appear to work, if you check on the bottom of any page in the preview, you will see this:

Screenshot from 2021-10-04 12-24-38

@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Oct 5, 2021

@trusktr
yea, I also checked the preview. but it works well locally. It seems some other issues here.

sy-records
sy-records requested changes Oct 5, 2021
View reviewed changes
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documents can add formatUpdated, but it is not necessary to add Last modified to index.html.

Because we use GitHub Pages, there are problems, see #1157

@Koooooo-7
Copy link
Member Author

Koooooo-7 commented Oct 5, 2021

@sy-records cool, I remove the code changes. and I will take a look on how to make it works as well.

@Koooooo-7 Koooooo-7 requested a review from sy-records October 5, 2021 08:46
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60428ce:

Sandbox Source
docsify-template Configuration

@sy-records sy-records changed the title update: update formatUpdated and docs. docs: update formatUpdated Oct 6, 2021
@Koooooo-7 Koooooo-7 merged commit f23f56a into develop Oct 6, 2021
@sy-records sy-records deleted the fix-format-date branch October 15, 2021 03:34
@Koooooo-7 Koooooo-7 mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sy-records sy-records sy-records approved these changes

@trusktr trusktr Awaiting requested review from trusktr

@jhildenbiddle jhildenbiddle Awaiting requested review from jhildenbiddle

@anikethsaha anikethsaha Awaiting requested review from anikethsaha

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koooooo-7 @trusktr @sy-records