fix: search titles containing ignored characters#1395
Merged
sy-records merged 11 commits intodocsifyjs:developfrom Nov 8, 2020
Merged
fix: search titles containing ignored characters#1395sy-records merged 11 commits intodocsifyjs:developfrom
sy-records merged 11 commits intodocsifyjs:developfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/adjwbyz46 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6e9c37:
|
anikethsaha
requested changes
Oct 13, 2020
Koooooo-7
previously approved these changes
Oct 13, 2020
Member
Koooooo-7
left a comment
Koooooo-7
left a comment
There was a problem hiding this comment.
As @anikethsaha said, try to write a test, so do I. 😜
Member
Author
|
Waiting for the #1398 merge to fix CI |
sy-records
force-pushed
the
fix-search-2
branch
from
9278a45 to
3c097f5
Compare
anikethsaha
approved these changes
Oct 15, 2020
Koooooo-7
approved these changes
Nov 8, 2020
jhildenbiddle
added a commit
that referenced
this pull request
Nov 11, 2020
commit a2ebb21 Author: 沈唁 <52o@qq52o.cn> Date: Sun Nov 8 16:48:43 2020 +0800 fix: search titles containing ignored characters (#1395) * fix: search titles containing ignored characters * fix * add default value * add test * fix test Co-authored-by: Koy <koy@ko8e24.top> commit 58fbca0 Author: Snyk bot <snyk-bot@snyk.io> Date: Thu Nov 5 03:04:19 2020 +0200 fix: packages/docsify-server-renderer/package.json & packages/docsify-server-renderer/package-lock.json to reduce vulnerabilities (#1418) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-DOMPURIFY-1035544
This was referenced Mar 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If ignore is set, we should remove it from the search title
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.