Skip to content

[Poc] feat(hook): new hook updateNav for update navbar content#1229

Draft
anikethsaha wants to merge 1 commit intodevelopfrom
new-hook-updateNav
Draft

[Poc] feat(hook): new hook updateNav for update navbar content#1229
anikethsaha wants to merge 1 commit intodevelopfrom
new-hook-updateNav

Conversation

@anikethsaha
Copy link
Member

@anikethsaha anikethsaha commented Jun 18, 2020

This is a working Proof of concept for the new hook updateNav

How to use it.

  function(hook, vm) {
      hook.updateNav(function(navContent) {
        return `${navContent}\n- new link\n- new link 2`
      });
}

@vercel
Copy link

vercel bot commented Jun 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/9h85au3g2
✅ Preview: https://docsify-preview-git-new-hook-updatenav.docsify-core.vercel.app

@anikethsaha anikethsaha mentioned this pull request Jun 18, 2020
Open
@anikethsaha anikethsaha mentioned this pull request Aug 17, 2020
Open
@stale
Copy link

stale bot commented Aug 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 17, 2020
@hamishwillee
Copy link

hamishwillee commented Feb 26, 2022 •
edited
Loading

Is there any intent to get this in?

The problem I have is that I do not want to include the translation path in my sources. If I do that, then my translators have to do make-work of manually updating the path in each URL. So what I want to do is read the current page path, get the translation string "e.g. /en", and insert is as a prefix in each of the links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anikethsaha @hamishwillee @sy-records