style: Get emoji from github api#1188
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/8dwzog2a2 |
anikethsaha
left a comment
anikethsaha
left a comment
There was a problem hiding this comment.
it seems you didnt change the api link in the img src.
let me know if I am missing something
|
Yeah, I'll modify it later. I'm not sure how to use it. What do you think? use key => value to get the src address directly, or use JavaScript to get the unicode value? |
|
I am not sure about github's api about emoji. is there any bug with the current setup ? |
|
No, but now the effect is the same as without plugin. It is not a complete emoji. I will modify it later. |
|
ok cool , you can convert this PR to draft and when ready , mark this as ready to review if its ok |
sy-records
changed the title
|
@anikethsaha @sy-records I'm look at the Now deploy, https://docsify-preview-git-fork-sy-records-style-emoji.docsify-core.now.sh/#/, and if you inspect the ❤️ it seems to use the old URL. Is the Now deploy not working? I thought it would have the new-style URL? I was expecting to see the URL with |
|
Because there is no emoji plugin loaded. |
|
I haven't tried it: what's the difference between with and without the emoji plugin? |
|
If not used, some emoji will not be displayed normally, for example |
anikethsaha
left a comment
anikethsaha
left a comment
There was a problem hiding this comment.
@sy-records can you add the emoji plugin in index.html in root directory so that we can have it in the preview.
otherwise looks good
|
@anikethsaha OK, I added. |
3 participants
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.