Updated embed to strip YAML front matter fixes #1129#1148
Merged
anikethsaha merged 1 commit intodocsifyjs:developfrom May 7, 2020
Merged
Updated embed to strip YAML front matter fixes #1129#1148anikethsaha merged 1 commit intodocsifyjs:developfrom
anikethsaha merged 1 commit intodocsifyjs:developfrom
Conversation
Update embeded files documentation Add example with front matter Add various comments I used to understand code Updated front matter to have installed flag Added function to parse front matter Added intercept to remove front matter for embed
sytone
changed the title
Member
|
thanks for the PR. It will be reviewed soon 👍 |
Koooooo-7
reviewed
Apr 28, 2020
Member
Koooooo-7
left a comment
Koooooo-7
left a comment
There was a problem hiding this comment.
After test, it works that skipped the YAML header. 👍
Contributor
Author
|
Any other questions on this one? Also if this goes into develop what is the propagation to master/release? I am considering pulling develop locally building and referencing that locally until pushed if it will take a while. This is an awesome system. I'm am building/using a personal journal system out of it as I write notes and journal entries in markdown to start with. Just have a simple powershell web server running it all. |
Member
|
I think its good. I will do a final review this weekend and will do a release by Monday 👍 |
Contributor
Author
|
Just following up to see if there were any issues. |
anikethsaha
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #1129 where embed was pulling through the YAML header when rendering pages as an embed. I did not want to pull the YAML parser by default. There are no rendering hooks for embed so I added a flag to check to see if the front matter plugin is installed and if it is use it to strip the content before returning the txt to render to the page.
FYI: I am not a JavaScript developer. :)
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.