[fix #1009] Trying fix emojis in titles not working correctly.#1016
Merged
anikethsaha merged 1 commit intodocsifyjs:developfrom Feb 14, 2020
Koooooo-7:develop
Merged
[fix #1009] Trying fix emojis in titles not working correctly.#1016anikethsaha merged 1 commit intodocsifyjs:developfrom Koooooo-7:develop
anikethsaha merged 1 commit intodocsifyjs:developfrom
Koooooo-7:develop
Conversation
Member
|
I will review it soon |
anikethsaha
requested changes
Feb 13, 2020
Member
anikethsaha
left a comment
There was a problem hiding this comment.
Well done 🎉
Just one note, can you document this. It will be good for users.
Member
|
@Koooooo-7 Thanks a lot for your time and the fix. The fix looks good. Just need to add notes in the docs for future ref !!! |
Member
Author
|
@anikethsaha |
the doc(add a note)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trying fix #1009 emojis in titles not working correctly ,
I attempt to think all the types likes
:words:as an emoji code that I wont replace it to empty(' ').At the same time, it causes another proplem that it cant solve
foo::ddd::cccas u want ever, the same as the time15:02:55. BUT i think it is acceptable, because :A: In my opnion, we doesnt render the
foo::ddd::ccc's title id correctly now.B: I think it is a good idea to put them within a code backticks that we can distinguish the title ,the emojis and the configurations easily at now.
TEST CASE
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.