Conversation
This makes it possible to depend on the docsify package using a git commit hash instead of a version number in package.json, and causes the `lib` folder to be built in those cases, otherwise consumers will try to import from a folder that doesn't exist.
anikethsaha
approved these changes
Jan 25, 2020
jamesgeorge007
suggested changes
Jan 26, 2020
Member
jamesgeorge007
left a comment
There was a problem hiding this comment.
Please resolve the conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes it possible to depend on the docsify package using a git commit hash instead of a version number in package.json, and causes the
libfolder to be built in those cases, otherwise consumers will try to import from a folder that doesn't exist.For example, in package.json the following,
tells
npmto getdocsifyfrom the branchprepare-scriptfrom http://github.com/docsifyjs/docsify.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.