Repository navigation
Emoji parsing should exclude URLs #1823
Description
Bug Report
Parsing of :emojis: should exclude URLs as this causes URLs in the following format render invalid HTML:
[link](https://link.com/:smile:/index)
Note that in my use case, I am also using other :emojis: so I can't set noEmoji: true in config.
Happy to contribute a fix if this bug is accepted.
Steps to reproduce
Example: https://codesandbox.io/s/brave-margulis-tw5t2b?file=/index.html
What is current behaviour
Invalid HTML is rendered:
<a alt="smile" src="https://github.githubassets.com/images/icons/emoji/smile.png" href="https://link.com/<img class=">/index" target="_blank" rel="noopener">link</a>
What is the expected behaviour
Rendered HTML should produce something like:
<a href="https://link.com/:smile:/index" target="_blank" rel="noopener">link</a>
Other relevant information
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: macOS
-
Node.js version:
-
npm/yarn version:
-
Browser version: Safari 15.5
-
Docsify version: 4
-
Docsify plugins:
Please create a reproducible sandbox
Mention the docsify version in which this bug was not present (if any)
Metadata
Metadata
Assignees
Labels
No labels
Activity
sy-records commentedon Jun 25, 2022
Thank you for your feedback.
Have you tried #1746?
socsieng commentedon Jul 5, 2022
I've tried with
nativeEmoji: trueand it still suffers from the same problem: https://codesandbox.io/s/practical-borg-nb3vdl?file=/index.htmljhildenbiddle commentedon Jul 30, 2022
@socsieng --
Ideally, docsify should handle this for you. If you're up for creating the PR, that would be great as I'm not sure I'll have the bandwidth anytime soon.
If you need a quick fix, you can just manually encode any portion of a URL that requires it (like a string matching the double-colon emoji pattern). You can do this using an online encode/decode tool or with the console in your browser's dev tools:
fix: Ignore emoji shorthand codes in URIs
fix: Ignore emoji shorthand codes in URIs (#1847)
[Release] v4.13.0 (#1912)
fix: Ignore emoji shorthand codes in URIs (#1847)