Repository navigation
Missing navbar with only coverpage #1696
Description
Bug Report
Steps to reproduce
- Set a navbar
loadnavbar: "_nav.md". - Set
onlyCover: true
What is current behaviour
The navbar is missing on first navigation to the page.
What is the expected behaviour
The navbar should exist unless set to false.
Other relevant information
If you go to an internal page and and
-
Bug does still occur when all/other plugins are disabled?
-
Your OS: Windows 10 x64
-
Node.js version: 14.17.5
-
npm/yarn version: 6.14.14
-
Browser version: Brave Version 1.33.106 Chromium: 96.0.4664.110 (Official Build) (64-bit)
-
Docsify version: 4.12.1
-
Docsify plugins: NA
Please create a reproducible sandbox
Sandbox link: https://codesandbox.io/s/elated-sound-6s1rq
Activity
trusktr commentedon Dec 28, 2021
@CxRes can you please provide a working reproduction? See the codesandbox link above.
trusktr commentedon Dec 28, 2021
Wait, nvm, i see the second link. The first one pointed to the default sandbox.
trusktr commentedon Dec 28, 2021
In your reproduction, there is no buttons on the cover page to go to any other page. I believe the expectation is that you will link to a page, then you will see a navbar on that page. Or no?
Does this work on any other sites?
If not, this may be a feature request. We could add an option to show navbar on cover-only pages (defaulting to false to be backward compatible).
PRs welcome!
CxRes commentedon Dec 28, 2021
@trusktr I added a button in the reproduction. There is no effect.
This is not a feature request! It is a BUG!!!
trusktr commentedon Dec 31, 2021
I'm not sure if this ever worked. I tried searching github for
"onlyCover true"and you can see there are only 5 results and they have a typo (onlycoverinstead ofonlyCover).We should have this ability regardless if its a bug or not.
trusktr commentedon Dec 31, 2021
pull request: #1706 (needs a test added for the feature)
jhildenbiddle commentedon Jun 16, 2024
Confirmed working as expected on
develop.