Repository navigation
Feature/shared UI components - #23
Merged
Merged
Conversation
… resolution tests
…h pan, zoom, node drag, and entity filters
…racted clauses, and status overlays
…esolution modal UX
…nflict resolution handlers
priyanshuvishwakarma273403
requested review from
Aidmann,
BixbyCodes,
DenizAltunkapan,
GideonBa and
MaximilianRau04
as code owners
August 23, 2026 13:08
MaximilianRau04
approved these changes
Aug 23, 2026
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Clean, behavior-preserving extraction. Good direction for reducing App.tsx (961 lines now) — worth applying to more components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR sets up and integrates a shared component package (
@docsgraph/ui) to prevent UI code duplication between the web and desktop client targets. It migrates theDocumentListItemcomponent into the shared package as a proof of concept and documents the UI contribution guidelines.Key Changes
1. Created Shared
DocumentListItemComponent (packages/ui/src/DocumentListItem.tsx)DocumentListItemProps) extending standardHTMLAttributes<HTMLButtonElement>.idmapping onto the HTML element.2. Exported Component (
packages/ui/src/index.ts)DocumentListItemandDocumentListItemPropsto public exports of the@docsgraph/uipackage.3. Integrated into Frontend (
apps/web/src/App.tsx)<DocumentListItem>insidedocuments.map()rendering of the "Available Documents" list.4. Documented Guidelines (
CONTRIBUTING.md)packages/ui.apps/.Verification & CI Status
pnpm lint: Passed (0 warnings/errors)pnpm typecheck: Passed (0 errors)pnpm build: Passedpnpm test: Passed (14/14 tests)