Repository navigation
Feature/contract analysis UI - #21
Merged
Merged
Conversation
… resolution tests
…h pan, zoom, node drag, and entity filters
…racted clauses, and status overlays
priyanshuvishwakarma273403
requested review from
Aidmann,
BixbyCodes,
DenizAltunkapan,
GideonBa and
MaximilianRau04
as code owners
August 23, 2026 12:40
MaximilianRau04
left a comment
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Party/clause/graph-focus wiring is real and correctly derived from data. Two spots are demo-only fixtures, not disclosed as such in the description.
…ils extraction to resolve PR comments
MaximilianRau04
approved these changes
Aug 24, 2026
MaximilianRau04
left a comment
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Verified: Key Details are now derived from real clause/doc content via regex extraction, and Retry Analysis does real client-side extraction instead of a blind timeout. Works for any document now, not just doc-1/2/3. One residual nit noted inline. Approving.
Addresses non-blocking review nit on #21: any never-analyzed document that wasn't literally id 'doc-2' fell into the else branch and was marked 'failed' by default instead of 'pending'. Now preserves an explicit prior 'failed' state (e.g. from a failed retry) and otherwise defaults to 'pending' for any document with no clauses yet, regardless of id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements a detailed Contract Details view surfacing automatically extracted metadata (signatories, key clauses, terms, and obligations) alongside document text in a modern dual-pane desktop view. It supports interactive passage linking, graph view highlighting, and asynchronous processing statuses (pending/failed/completed).
Key Changes
1. Dual-Pane Contract Detail View (
apps/web/src/App.tsx)🔍 Show: Auto-scrolls and highlights the exact clause sentence inside the document body.🌐 Graph: Switches to the Graph View and focuses on the selected clause node.2. Analysis Status State Handling (
apps/web/src/App.tsx)doc-1): Surfaces the full list of extracted parties, clauses, and metadata terms.doc-2): Displays an animated skeleton loader indicating contract structure parsing is still in progress.doc-3): Displays an error card with error codes and a fully functioning "Retry Analysis" button. Retrying simulates re-parsing and dynamically completes analysis in 2 seconds.3. Graph Focus & Highlight Indicators (
packages/graph-view/src/GraphView.tsx)highlightNodeIdcamera-centering capabilities.Verification Results
pnpm lint: Passed (0 warnings/errors)pnpm test: Passed (14/14 tests)