Repository navigation
Feature/obsidian graph view - #20
Merged
Merged
Conversation
… resolution tests
…h pan, zoom, node drag, and entity filters
priyanshuvishwakarma273403
requested review from
Aidmann,
BixbyCodes,
DenizAltunkapan,
GideonBa and
MaximilianRau04
as code owners
August 23, 2026 12:33
MaximilianRau04
requested changes
Aug 23, 2026
MaximilianRau04
left a comment
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Graph rendering and data wiring are solid, but node dragging as described in the PR does not actually work.
…d restart simulation on interaction
MaximilianRau04
approved these changes
Aug 24, 2026
MaximilianRau04
left a comment
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Verified: drag now correctly references the live simNodes via a ref, and mousemove/mouseup already pointed at the same ref. Actually works now. One non-blocking edge case noted inline. Approving.
MaximilianRau04
left a comment
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Non-blocking nit, not a re-request.
…ng drag ref on re-render Addresses non-blocking review nit on #20: filteredNodes/filteredEdges were recomputed on every render and were the sim useEffect's deps, so an unrelated parent re-render mid-drag could rebuild simNodesRef.current and orphan draggedNodeRef.current. Now memoized on their actual inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements an interactive, Obsidian-style knowledge graph view for visualizing documents, parties, clauses, and their relationships. It replaces the minimal graph rendering with a fully interactive canvas simulation.
Key Changes
1. Interactive Graph Visualization (
packages/graph-view/src/GraphView.tsx)'signed_by','contains') directly on the links.2. SQLite Entity Loading & Navigation (
apps/web/src/App.tsx&packages/data/src/store.ts)getClauses()retrieval methods to the SQLite data layer.onNodeClicknavigation:Verification Results
pnpm lint: Passed (0 warnings/errors)pnpm test: Passed (14/14 tests)