Repository navigation
Feature/grounded search UI - #19
Merged
Merged
Conversation
… resolution tests
priyanshuvishwakarma273403
requested review from
Aidmann,
BixbyCodes,
DenizAltunkapan,
GideonBa and
MaximilianRau04
as code owners
August 23, 2026 12:25
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Search itself is real and correctly grounded. The in-memory adapter's SQL matching is brittle enough to silently drop writes.
…nMemorySqliteAdapter to prevent silent no-ops
MaximilianRau04
approved these changes
Aug 24, 2026
MaximilianRau04
left a comment
Contributor
There was a problem hiding this comment.
Verified: the new parser correctly handles the MAX(COALESCE(...)) update, relationships now has UPDATE support, and unrecognized queries throw instead of silently no-oping. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the local offline evidence-grounded search capabilities for
docsgraph. It enables users to search across their local document library and retrieve matching passages, linking search results directly back to the source document with precise offset highlighting.Key Changes
1. Offline Search Implementation (
packages/search/src/search.ts)LocalStoreand query it fully offline.[start, end)).2. Search UI and Document Viewer (
apps/web/src/App.tsx)3. In-Memory SQLite Emulator (
packages/data/src/sqlite/in-memory.ts)InMemorySqliteAdapterimplementing theSqliteAdapterinterface.4. Verification & Testing
packages/search/src/search.test.ts(verifying exact matching and offset calculation).src/App.test.tsxby keeping the required elements (e.g. GraphView canvas and header buttons) present in the DOM.Verification Results
pnpm lint: Passed (0 warnings/errors)pnpm test: Passed (14/14 tests)