fix: carry per-user edit permission into all sidebar tree nodes - #2433
Open
shraav185 wants to merge 1 commit into
Open
fix: carry per-user edit permission into all sidebar tree nodes#2433shraav185 wants to merge 1 commit into
shraav185 wants to merge 1 commit into
Conversation
Closes docmost#2357. The sidebar tree already disables drag-and-drop for users who cannot manage pages, but three paths could still insert nodes without permission data, letting restricted/read-only pages be dragged (failing server-side with an error toast): - /pages/breadcrumbs now returns each ancestor's effective canEdit for the requesting user (mirroring getSidebarPages), so lazy-loaded ancestor nodes in the sidebar carry correct editability. - Realtime addTreeNode events backfill the receiving user's canEdit via /pages/info and remove the node entirely if the user cannot view it. - Optimistically created nodes are stamped with canEdit: true. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2357. The sidebar tree already disables drag-and-drop for users who cannot manage pages, but three paths could still insert nodes without permission data, letting restricted/read-only pages be dragged (failing server-side with an error toast):