This repository was archived by the owner on Oct 26, 2019. It is now read-only.
[WIP] Refactoring of Docker-PHP #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
So tests are green :) Incoming object are now correctly serialized with last update from the jane swagger library. Missing parts :
|
Member
Author
|
poke @hacfi, don't know if you are still using docker-php, will be glad to have some inputs for this. |
Closed
Contributor
|
@joelwurtz Will review it on the weekend. Generally I really like the concept of Jane! |
This was referenced Jan 11, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This is a pretty long PR, and a work of several months on many libraries.
To know how it works see my last post on #46
TL; DR; We know just have to maintain the swagger specification and a tiny layer around the generated code to have a better user experience, but there in this PR a 100% coverage of all docker calls.
You can test this at your own risk.
For the moment this is completly BC with the old library, i don't think we will provide some sort of compatibility layer unless someone want to write it.
This should also fix other issue like #139, #122, #96, #30, #138 and #108
There is still some works to do on the jane/swagger library to handle incoming object to be serialized in the request.
I'm also wondering about moving this under the
Enginenamespace, so we can add registry, index and others api from Docker WDYT @ubermuda ?