Skip to content
This repository was archived by the owner on Oct 26, 2019. It is now read-only.
This repository was archived by the owner on Oct 26, 2019. It is now read-only.

PhpDoc FQCN vs namespaces #110

@hacfi

Description

@hacfi

Working on some PRs I noticed that the PhpDocs always use the full FQCN (see https://github.com/stage1/docker-php/blob/master/src/Docker/Docker.php#L30)

Example:
https://github.com/stage1/docker-php/blob/master/src/Docker/Docker.php#L30

    /**
     * @var \Docker\Manager\ImageManager
     */
    private $imageManager;

instead of just @var ImageManager.

Do you want to keep this or can I create a PR getting rid of the unnecessary long FQCN names? If so, should I add the use statements for classes which aren’t used in the PHP code but just in the PhpDocs?

See http://www.phpdoc.org/docs/latest/guides/types.html#class-name that this is valid PhpDoc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions