Skip to content

Fix the structure of blkio_stats#969

Closed
yuting-liu wants to merge 9 commits intodocker-java:masterfrom
yuting-liu:yuting-stats
Closed

Fix the structure of blkio_stats#969
yuting-liu wants to merge 9 commits intodocker-java:masterfrom
yuting-liu:yuting-stats

Conversation

@yuting-liu
Copy link
Copy Markdown
Contributor

@yuting-liu yuting-liu commented Jan 3, 2018 •
edited by marcuslinke
Loading

This change is Reviewable

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Jan 3, 2018

Looks like breaking change. When did they change this field to object?

@yuting-liu
Copy link
Copy Markdown
Contributor Author

yuting-liu commented Jan 3, 2018

It's my fault that in my previous PR #957. I created the live instance but these fields are empty, so I mistakenly thought them as List<Long>. However, I just found that it's kind of List of Objects, each of them with four fields major, minor, op, and value.

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Jan 3, 2018

So could you create some tests?

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 4, 2018 •
edited
Loading

Codecov Report

Merging #969 into master will decrease coverage by 0.06%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
- Coverage    59.5%   59.44%   -0.07%     
==========================================
  Files         440      439       -1     
  Lines        8725     8697      -28     
  Branches      538      538              
==========================================
- Hits         5192     5170      -22     
+ Misses       3236     3229       -7     
- Partials      297      298       +1
Impacted Files Coverage Δ
...va/com/github/dockerjava/api/model/Statistics.java 90% <ø> (ø) ⬆️
.../github/dockerjava/api/model/BlkioStatsConfig.java 100% <ø> (+14.28%) ⬆️
...github/dockerjava/api/model/IoRecursiveConfig.java 87.5% <87.5%> (ø) ⬆️
...com/github/dockerjava/api/model/ContainerPort.java 6.25% <0%> (-12.5%) ⬇️
...om/github/dockerjava/api/model/ContainerMount.java 4% <0%> (-8%) ⬇️
...ava/netty/handler/FramedResponseStreamHandler.java 84.48% <0%> (-3.45%) ⬇️
...com/github/dockerjava/netty/InvocationBuilder.java 90.86% <0%> (-0.92%) ⬇️
...om/github/dockerjava/api/model/BlkioStatEntry.java

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f196c02...f932c20. Read the comment docs.

@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Jan 10, 2018

please rebase & squash into one commit and let me know when you are ready, i will merge.

@KostyaSha KostyaSha mentioned this pull request Sep 27, 2018
Merged
@KostyaSha KostyaSha added this to the 3.1.0-rc-6 milestone Oct 15, 2018
@KostyaSha
Copy link
Copy Markdown
Member

KostyaSha commented Oct 15, 2018

picked in #1109 thanks!

@KostyaSha KostyaSha closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0-rc-6

Development

Successfully merging this pull request may close these issues.

3 participants

@yuting-liu @KostyaSha @codecov-io