Skip to content

Add support of pids_stats of Docker Remote API 1.23#952

Closed
yuting-liu wants to merge 1 commit intodocker-java:masterfrom
yuting-liu:yuting-docker-metrics
Closed

Add support of pids_stats of Docker Remote API 1.23#952
yuting-liu wants to merge 1 commit intodocker-java:masterfrom
yuting-liu:yuting-docker-metrics

Conversation

@yuting-liu
Copy link
Copy Markdown
Contributor

@yuting-liu yuting-liu commented Nov 22, 2017

In https://docs.docker.com/engine/api/version-history/, it shows that

GET /containers/(id or name)/stats now returns pids_stats, if the kernel is >= 4.3 and the pids cgroup is supported.

Already read README.md, showing that the latest version now is supporting a subset of remote API 1.23. Hoping to use this stats so created this PR to add the support this feature.


This change is Reviewable

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #952 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   61.89%   61.91%   +0.01%     
==========================================
  Files         410      410              
  Lines        8152     8153       +1     
  Branches      521      521              
==========================================
+ Hits         5046     5048       +2     
  Misses       2809     2809              
+ Partials      297      296       -1
Impacted Files Coverage Δ
...va/com/github/dockerjava/api/model/Statistics.java 10% <0%> (-1.12%) ⬇️
...ava/netty/handler/FramedResponseStreamHandler.java 87.93% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f4827...95d9080. Read the comment docs.

@KostyaSha
Copy link
Copy Markdown
Member

could you rebase?

@KostyaSha
Copy link
Copy Markdown
Member

superseed by #957

@KostyaSha KostyaSha closed this Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants