Skip to content

Add awaitSuccess with timeout while pulling image #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hazim1093 wants to merge 1 commit into from
Closed

Add awaitSuccess with timeout while pulling image #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/main/java/com/github/dockerjava/core/command/PullImageResultCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,25 @@ public void awaitSuccess() {
throw new DockerClientException("Could not pull image: " + message);
}
}

/**
* Awaits the image to be pulled successful, with timeout
*
* @throws DockerClientException
* if the pull fails.
*/
public void awaitSuccess(long timeout, TimeUnit timeUnit) {
try {
awaitCompletion(timeout, timeUnit);
} catch (InterruptedException e) {
throw new DockerClientException("", e);
}

if (latestItem == null) {
Copy link
Copy Markdown
Contributor

@orzeh orzeh Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazim1093 why do you duplicate this code? Extract it to separate method, see BuildImageResultCallback for reference

throw new DockerClientException("Could not pull image");
} else if (!latestItem.isPullSuccessIndicated()) {
String message = (latestItem.getError() != null) ? latestItem.getError() : latestItem.getStatus();
throw new DockerClientException("Could not pull image: " + message);
}
}
}