Add awaitSuccess with timeout while pulling image#939
Closed
hazim1093 wants to merge 1 commit intodocker-java:3.0.xfrom
Closed
Add awaitSuccess with timeout while pulling image#939hazim1093 wants to merge 1 commit intodocker-java:3.0.xfrom
hazim1093 wants to merge 1 commit intodocker-java:3.0.xfrom
Conversation
orzeh
reviewed
Oct 25, 2017
| throw new DockerClientException("", e); | ||
| } | ||
|
|
||
| if (latestItem == null) { |
Contributor
There was a problem hiding this comment.
@hazim1093 why do you duplicate this code? Extract it to separate method, see BuildImageResultCallback for reference
fbuecklers
added a commit
to Baqend/java-docker-driver
that referenced
this pull request
Oct 25, 2017
fbuecklers
added a commit
to Baqend/java-docker-driver
that referenced
this pull request
Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm facing a scenario where Image pulling is taking a lot of time and I need it to timeout after a specific time. The pull request includes an overloaded
awaitSuccessmethod which calls the overloadedawaitCompletion(timeout, timeoutUnit)method (already provided), instead of theawaitCompletion()method.This change is