Skip to content

add labels and attachable properties to network #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KostyaSha merged 1 commit into from
Jun 3, 2017
Merged

add labels and attachable properties to network #844

KostyaSha merged 1 commit into from
Jun 3, 2017

Conversation

@fengxx
Copy link
Contributor

@fengxx fengxx commented May 18, 2017 •
edited by marcuslinke
Loading

This change is Reviewable

@fengxx fengxx force-pushed the feature/1.24_network branch from 816ea98 to af22a40 Compare May 18, 2017 11:37
@codecov-io
Copy link

codecov-io commented May 18, 2017 •
edited
Loading

Codecov Report

Merging #844 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   71.63%   71.66%   +0.02%     
==========================================
  Files         306      306              
  Lines        6643     6655      +12     
  Branches      500      500              
==========================================
+ Hits         4759     4769      +10     
- Misses       1591     1593       +2     
  Partials      293      293
Impacted Files Coverage Δ
.../dockerjava/core/command/CreateNetworkCmdImpl.java 67.74% <100%> (+9.4%) ⬆️
.../java/com/github/dockerjava/api/model/Network.java 65.11% <60%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ac9b6...d700d72. Read the comment docs.

KostyaSha
KostyaSha reviewed May 23, 2017
View reviewed changes
src/main/java/com/github/dockerjava/api/command/CreateNetworkCmd.java Outdated
CreateNetworkCmd withEnableIpv6(boolean enableIpv6);


CreateNetworkCmd withAttachable(boolean attachable);
Copy link
Member

@KostyaSha KostyaSha May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use Boolean

KostyaSha
KostyaSha reviewed May 23, 2017
View reviewed changes
src/main/java/com/github/dockerjava/api/model/Network.java Outdated
}

public boolean isAttachable() {
return attachable == null ? false : attachable;
Copy link
Member

@KostyaSha KostyaSha May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please return raw value, on end-user code you can wrap it simply with BooleanUtils
null in return value means that there is no value. No value != false from req/rsp view point.

@KostyaSha
Copy link
Member

KostyaSha commented May 23, 2017

please ADD since 1.24 (?) annotations for fields

@fengxx fengxx force-pushed the feature/1.24_network branch from af22a40 to 7846537 Compare May 24, 2017 03:04
@fengxx
Copy link
Contributor Author

fengxx commented May 24, 2017 •
edited
Loading

Labels for network was added in 1.24, can be viewed on https://github.com/moby/moby/blob/master/docs/api/v1.24.md.
I am not sure about "Attachable", checked 1.18 -> 1.24, no mention in the doc, but python-api is using it in 1.21, and it is only required when create overlay network in swarm cluster.

@fengxx fengxx force-pushed the feature/1.24_network branch from 7846537 to b91fb95 Compare May 24, 2017 04:14
@fengxx fengxx force-pushed the feature/1.24_network branch from b91fb95 to d700d72 Compare May 24, 2017 04:17
@KostyaSha KostyaSha added this to the 3.0.11 milestone Jun 3, 2017
@KostyaSha KostyaSha merged commit 8f71887 into docker-java:master Jun 3, 2017
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
@KostyaSha
Merge pull request docker-java#844 from fengxx/feature/1.24_network
7206e6e 
add labels and attachable properties to network
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KostyaSha KostyaSha KostyaSha left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.11

Development

Successfully merging this pull request may close these issues.

3 participants

@fengxx @codecov-io @KostyaSha