Add pidsLimit option when creating containers #779#780
Closed
menarguez wants to merge 2 commits intodocker-java:masterfrom
Closed
Add pidsLimit option when creating containers #779#780menarguez wants to merge 2 commits intodocker-java:masterfrom
menarguez wants to merge 2 commits intodocker-java:masterfrom
Conversation
docker-java#779 Enable pid limitation is a cgroups configuration that is able to limit the number of processes that a container can create. This setting is extremely useful as it can prevent fork bombs. For more details see pids.max https://www.kernel.org/doc/Documentation/cgroup-v1/pids.txt
Author
|
Hi please comment and merge this change or #734. Thank you very much! |
Member
|
Replaced by #764 |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable pid limitation is a cgroups configuration that is able to limit the number of processes that a container can create. This setting is extremely useful as it can prevent fork bombs.
For more details see pids.max https://www.kernel.org/doc/Documentation/cgroup-v1/pids.txt
I have created a fix for this and will soon submit a pull request to HostConfig.java with Testing done.
This change is