Adds network labels to createNetworkCmd and Network domain#760
Closed
cirocosta wants to merge 1 commit intodocker-java:masterfrom
Closed
Adds network labels to createNetworkCmd and Network domain#760cirocosta wants to merge 1 commit intodocker-java:masterfrom
createNetworkCmd and Network domain#760cirocosta wants to merge 1 commit intodocker-java:masterfrom
Conversation
Contributor
|
It would be super-awesome if someone can merge this simple, but necessary fix. |
marcuslinke
reviewed
Jan 20, 2017
|
|
||
|
|
||
| @Test | ||
| public void createNetworkWithLabels() throws DockerException { |
Contributor
There was a problem hiding this comment.
Could you add this test to CreateNetworkCmdExecTest also please?
Member
There was a problem hiding this comment.
test will fail on 1.22, so pr builder will also fail
Codecov Report@@ Coverage Diff @@
## master #760 +/- ##
==========================================
+ Coverage 71.11% 71.24% +0.12%
==========================================
Files 303 303
Lines 6547 6551 +4
Branches 592 592
==========================================
+ Hits 4656 4667 +11
+ Misses 1607 1602 -5
+ Partials 284 282 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
it looks like we're missing
Labelson bothNetworkdomain andCreateNetworkCmd.I'm not sure if all followed all the conventions. Please tell me how can i fix it if something is missing. Thx!
This change is