Skip to content

Conversation

@KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Sep 29, 2016

@codecov-io
Copy link

codecov-io commented Sep 29, 2016

Codecov Report

Merging #717 into master will decrease coverage by 10.2%.
The diff coverage is 5.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #717       +/-   ##
===========================================
- Coverage    71.9%   61.69%   -10.21%     
===========================================
  Files         306      411      +105     
  Lines        6858     8107     +1249     
  Branches      509      519       +10     
===========================================
+ Hits         4931     5002       +71     
- Misses       1634     2812     +1178     
  Partials      293      293
Impacted Files Coverage Δ
...a/com/github/dockerjava/core/RemoteApiVersion.java 76.59% <ø> (ø) ⬆️
.../com/github/dockerjava/api/model/Reachability.java 0% <0%> (ø)
...b/dockerjava/core/command/InspectSwarmCmdImpl.java 0% <0%> (ø)
...thub/dockerjava/jaxrs/InspectSwarmNodeCmdExec.java 0% <0%> (ø)
...dockerjava/core/command/ListSwarmNodesCmdImpl.java 0% <0%> (ø)
.../dockerjava/core/command/CreateServiceCmdImpl.java 0% <0%> (ø)
...dockerjava/core/util/SwarmNodesFiltersBuilder.java 0% <0%> (ø)
.../dockerjava/netty/exec/InitializeSwarmCmdExec.java 0% <0%> (ø)
...erjava/api/model/ServiceReplicatedModeOptions.java 0% <0%> (ø)
...m/github/dockerjava/api/model/BindPropagation.java 0% <0%> (ø)
... and 214 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd1ce1...aba519c. Read the comment docs.

KostyaSha and others added 6 commits June 29, 2017 11:52
Apply changes from review

Remove unused import

Fix compile errors
Add ListNodes implementation

Fix error in ListNodesCmdExec

Add FilterBuilder for swarmNodes, renamed Node to SwarmNode

Update model classes for SwarmNodes

add implementation for update,list,remove and inspect of a swarmNode

Update model classes for docker-swarm-node

Add methods for swarmNode to execFactories
Fix service tests

Add missing withDriver() method

Fix json name of Networks in ServiceSpec

Add tests to add network to services

Do not fail on empty beans
Fix swarm LocalNodeState

Change deserialiser
@KostyaSha KostyaSha merged commit 2027416 into master Jul 5, 2017
@KostyaSha
Copy link
Member Author

swarm Node object
classic swarm pulling by @hawky-4s- #716

TODO review it as separate PRs.

panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
Swarm branch to future 3.1.0 master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants