Issue 674: 3.0.x scheme switch for docker host breaks proxy configure#675
Conversation
…cp breaks proxy configure docker-java#674 With the 3.0.x release, the code has been changed to use docker hosts of the format: tcp://host:port Instead of: https://host:port This breaks some of the logic in JerseyDockerCmdExecFactory that configures the proxy setting.
|
LGTM |
|
Could you also try NETTY impl? Maybe it also broken. |
|
@KostyaSha, I'll give try out the netty impl. Thanks. |
|
@KostyaSha, it doesn't look like the netty implementation has any support for proxies at the moment. I'm up for adding it but if it is okay with you I'd rather add it in a separate PR. |
|
@loganbruns Would be great if you could add the netty stuff within this PR. |
|
@marcuslinke, @KostyaSha: I implemented the changes for netty but it doesn't work properly with the netty pipeline. It has problem resolving the proxy host. I'd like to try it with netty 5 but that may be a larger change. Also I'd like to create a separate unrelated PR to change some of the SSL context handling and I'd like to get off our custom build of docker-java (using this branch.) I guess I'd like to ask again to merge this PR and then follow up with other PRs (one for netty upgrade and proxy changes) and the other some unrelated SSL changes. |
|
A brief nag. This PR fixes a bug that prevents using the standard docker-java build from working in many corporate environments that require the use of a proxy. Granted it would be best if this PR fixed the problem for both networking providers but it does at least for the default provider, jersey, and a best faith effort was made for netty as well but there are a number of difficulties. Fixing it for netty is a larger project that probably be in a separate set of PRs starting with catching up with the current version. |
|
@marcuslinke, thanks! |
…cp breaks proxy configure (docker-java#675) docker-java#674 With the 3.0.x release, the code has been changed to use docker hosts of the format: tcp://host:port Instead of: https://host:port This breaks some of the logic in JerseyDockerCmdExecFactory that configures the proxy setting.
3 participants
Issue: #674
With the 3.0.x release, the code has been changed to use docker hosts of the format:
tcp://host:port
Instead of:
https://host:port
This breaks some of the logic in JerseyDockerCmdExecFactory that configures the proxy setting.
This change is