-
Notifications
You must be signed in to change notification settings - Fork 1.1k
added event type in Event class #650 #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI check is failing because of older docker api version i.e. 1.20 Need to change this to 1.24, can any of the moderators help here? |
| private Node node; | ||
|
|
||
| @JsonProperty("Type") | ||
| private String type; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add javadoc@since RAP.. (see examples in existing methods)
|
Add in netty and jersey test classes check for this field in conditional situation like in https://github.com/docker-java/docker-java/pull/642/files#r72670628 |
|
I have pre-defined reply:
|
| return node; | ||
| } | ||
|
|
||
| @JsonProperty("Type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need it, because you put it on field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CheckForNull
|
@KostyaSha I have made the required changes as you suggested. Still the build is failing, it seems that test suite is not able to connect to Docker host. Is there something else which I am missing here ? |
|
will check as soon as find free time |
|
Could you provide JSON of some event from real system to make test? |
|
nevermind, picked from docs |
|
Great !! |
This change is