Skip to content

Conversation

@Paritosh-Anand
Copy link

@Paritosh-Anand Paritosh-Anand commented Aug 1, 2016

This change is Reviewable

@Paritosh-Anand
Copy link
Author

CI check is failing because of older docker api version i.e. 1.20

Need to change this to 1.24, can any of the moderators help here?

docker version
Client:
 Version:      1.8.2
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   0a8c2e3
 Built:        Wed Oct  7 17:48:28 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.2
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   0a8c2e3
 Built:        Wed Oct  7 17:48:28 UTC 2015
 OS/Arch:      linux/amd64

private Node node;

@JsonProperty("Type")
private String type;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add javadoc@since RAP.. (see examples in existing methods)

@KostyaSha
Copy link
Member

Add in netty and jersey test classes check for this field in conditional situation like in https://github.com/docker-java/docker-java/pull/642/files#r72670628

@KostyaSha
Copy link
Member

KostyaSha commented Aug 2, 2016

I have pre-defined reply:

return node;
}

@JsonProperty("Type")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need it, because you put it on field

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CheckForNull

@Paritosh-Anand
Copy link
Author

@KostyaSha I have made the required changes as you suggested. Still the build is failing, it seems that test suite is not able to connect to Docker host. Is there something else which I am missing here ?

@KostyaSha
Copy link
Member

will check as soon as find free time

@KostyaSha KostyaSha mentioned this pull request Aug 16, 2016
@KostyaSha
Copy link
Member

Could you provide JSON of some event from real system to make test?

@KostyaSha
Copy link
Member

nevermind, picked from docs

@KostyaSha KostyaSha added this to the 3.0.5 milestone Aug 17, 2016
@Paritosh-Anand
Copy link
Author

Great !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants