Skip to content

[CID-125822] Fix resource leak #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KostyaSha merged 1 commit into from
Jul 7, 2016
Merged

[CID-125822] Fix resource leak #622

KostyaSha merged 1 commit into from
Jul 7, 2016

Conversation

@KostyaSha
Copy link
Member

@KostyaSha KostyaSha commented Jul 4, 2016 •
edited by marcuslinke
Loading

This change is Reviewable

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

$ export DOCKER_HOST="unix:///var/run/docker.sock"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 301, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 519.736 sec <<< FAILURE! - in TestSuite
copyFileToContainer(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.456 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@47f5d8cf; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyFileToContainer(CopyArchiveToContainerCmdImplTest.java:57)
copyStreamToContainer(com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest)  Time elapsed: 0.448 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@5f37f5c0; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.assertFileCopied(CopyArchiveToContainerCmdImplTest.java:83)
    at com.github.dockerjava.core.command.CopyArchiveToContainerCmdImplTest.copyStreamToContainer(CopyArchiveToContainerCmdImplTest.java:66)
testStatsStreaming(com.github.dockerjava.core.command.StatsCmdImplTest)  Time elapsed: 4.21 sec  <<< FAILURE!
javax.ws.rs.ProcessingException: Error closing message content input stream.
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: java.io.IOException: Bad file descriptor at Socket[addr=0.0.0.0/0.0.0.0,port=0,localport=0][fd=java.io.FileDescriptor@545091ca; file=/run/docker.sock; connected=false; bound=false]
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Caused by: org.newsclub.net.unix.AFUNIXSocketException: Bad file descriptor
    at com.github.dockerjava.core.command.StatsCmdImplTest.testStatsStreaming(StatsCmdImplTest.java:73)
Results :
Failed tests: 
  CopyArchiveToContainerCmdImplTest.copyFileToContainer:57->assertFileCopied:83 » Processing
  CopyArchiveToContainerCmdImplTest.copyStreamToContainer:66->assertFileCopied:83 » Processing
  StatsCmdImplTest.testStatsStreaming:73 » Processing Error closing message cont...
Tests run: 301, Failures: 3, Errors: 0, Skipped: 0

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

$ export DOCKER_HOST="tcp://127.0.0.1:2375"
$ export DOCKER_VERSION="1.11.2-0~trusty"

Tests run: 301, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 483.355 sec <<< FAILURE! - in TestSuite
attachContainerWithTTY(com.github.dockerjava.core.command.AttachContainerCmdImplTest)  Time elapsed: 8.839 sec  <<< FAILURE!
java.lang.AssertionError: 
Expected: a string containing "stdout\r\nstderr"
     but: was ""
    at com.github.dockerjava.core.command.AttachContainerCmdImplTest.attachContainerWithTTY(AttachContainerCmdImplTest.java:108)
Results :
Failed tests: 
  AttachContainerCmdImplTest.attachContainerWithTTY:108 
Expected: a string containing "stdout\r\nstderr"
     but: was ""
Tests run: 301, Failures: 1, Errors: 0, Skipped: 0

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 4, 2016

The same errors as before.

@marcuslinke review?

@KostyaSha
Copy link
Member Author

KostyaSha commented Jul 7, 2016

successfully passed as part of #620 , merging.

@KostyaSha KostyaSha merged commit e5a1cd8 into master Jul 7, 2016
@KostyaSha KostyaSha deleted the fixIT3 branch July 21, 2016 23:48
panuse pushed a commit to TuKangTech/docker-java that referenced this pull request Aug 20, 2017
@KostyaSha
Merge pull request docker-java#622 from docker-java/fixIT3
55d1504 
[CID-125822] Fix resource leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KostyaSha