Seems we would need a test case for it

Codecov Report

❗ No coverage uploaded for pull request base (master@8be5180). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #521   +/-   ##
=========================================
  Coverage          ?   71.77%           
=========================================
  Files             ?      306           
  Lines             ?     6598           
  Branches          ?      487           
=========================================
  Hits              ?     4736           
  Misses            ?     1575           
  Partials          ?      287

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be5180...c1b7ace. Read the comment docs.

Hi,

I change my chectstyle environment to be compliant with us.
I add a test integration too.

Best Regards

Frédéric.

Missing netty implementation.
Would this change be backward compatible with previous (docker daemon) API versions?

As i see save Save an image(s) to a tar archive

Usage:  docker save [OPTIONS] IMAGE [IMAGE...]

Save an image(s) to a tar archive (streamed to STDOUT by default)

  --help             Print usage
  -o, --output       Write to a file, instead of STDOUT

Requires only image name. But docker API also allows passing names query. So as library we should support all this options.

https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.22.md#get-a-tarball-containing-all-images-in-a-repository contains some https://github.com/docker/docker/blob/master/docs/reference/api/docker_remote_api_v1.22.md#image-tarball-format format. Could you check whether this format is right now and whether it possible implement some integration test (tag something (i.e. busybox) with test specific repository name and verify that returned archive contains tags/images). I think you can add commons-compress into test scope if it missing?

Test would allow cover situations and avoid breakage in future.

@draoullig Ping!

Hi,

I don't have time to contribue at this project.
I made this patch to solve the bug in a jenkins plugin.
I send you this solution to fix the bug even all the differents uses cases are not covered.

Best regards.

Frédéric

@draoullig thanks, it will take some time to update your changes and we will merge later.

retriggering pr build

Any chance we could get this PR massaged and cleaned up and merged?

Any chance we could get this PR massaged and cleaned up and merged?

Too busy on this week, i can press merge and run relese. Could you PR picking this commits?

#1155