Fix issue #456 in master branch #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Use fixup, they will keep original author in commits ! |
Contributor
Author
|
Original PR was against 2.x branch. I fixed the same issue in the master branch separately as it was significantly changed meanwhile and merging/picking commits will be more painful. |
Member
|
git checkout -b newBranch |
Contributor
Author
|
What should this do? |
Contributor
Author
|
@KostyaSha OK. Now it got it. Sorry I'm not very familar with rebasing... Closing this and open #464 instead. |
Member
|
@marcuslinke no problems, just think that it good idea to keep original authors in commits. Fixup/rebase are pretty simple. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #457 for 2.x branch