Make AuthConfig fluent, setters -> with. #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I failed checkstyle :) |
| } | ||
|
|
||
| public void setServerAddress(String serverAddress) { | ||
| public AuthConfig withServerAddress(String serverAddress) { |
Contributor
There was a problem hiding this comment.
Not sure if this should be included in this PR but I suggest to rename method to withRegistryUrl. WDYT?
Member
Author
There was a problem hiding this comment.
I think it not url, it just addr:port. Probably withRegistryAddr is better
KostyaSha
changed the title
Member
Author
|
@marcuslinke added as separate commit |
| } | ||
|
|
||
| public void setServerAddress(String serverAddress) { | ||
| public AuthConfig withRegistryAddres(String serverAddress) { |
Contributor
There was a problem hiding this comment.
rename argument also please
Member
Author
|
:E done |
This is more correct as auth used only for pull/push operations.
Contributor
|
LGTM. Feel free to merge! |
KostyaSha
added a commit
that referenced
this pull request
Feb 9, 2016
Make AuthConfig fluent, setters -> with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #453