Add a boolean parameter to indicate if Frame is complete - #2050
Closed
yuting-liu wants to merge 2 commits into
Closed
Add a boolean parameter to indicate if Frame is complete#2050yuting-liu wants to merge 2 commits into
yuting-liu wants to merge 2 commits into
Conversation
Contributor
Author
|
@bsideup Can you please help to review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous PR (#1754), already had some discussions with @bsideup about the
FrameInputConsumer.In previous thread: #1754 (comment):
Since as the client side, we already lose the information to know what is the payload size. We need a way at the client side to know if frames are complete and thus glue multiple frames together. Thus, I want to add a boolean parameter in the
Framethus we can do the concatenation at out end