Handle network aliases without a custom network gracefully #1942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidando73
commented
Sep 10, 2022
| if (containerNetwork != null) { | ||
| if (containerNetwork != null && hostConfig.getNetworkMode() != null) { | ||
| networkingConfig = new NetworkingConfig() | ||
| .withEndpointsConfig(singletonMap(hostConfig.getNetworkMode(), containerNetwork)); |
Contributor
Author
There was a problem hiding this comment.
Exception was being thrown as we were putting:
EndpointsConfig: {
null: containerNetwork
}
as networkMode is null by default. This can't be serialised by JSON so it throws.
eddumelendez
approved these changes
Sep 12, 2022
Member
eddumelendez
left a comment
eddumelendez
left a comment
There was a problem hiding this comment.
LGTM, just waiting for @bsideup review
bsideup
reviewed
Sep 13, 2022
docker-java/src/test/java/com/github/dockerjava/cmd/CreateContainerCmdIT.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you @eddumelendez and @bsideup for the review. I've addressed your suggestions. |
Member
|
Thanks for your contribution @REslim30 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1940