Skip to content

add missing param Init in ContainerSpec #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddumelendez merged 3 commits into from
Sep 19, 2022
Merged

add missing param Init in ContainerSpec #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e70635
add missing param Init in ContainerSpec
Aug 22, 2022
a9ca9d8
add comment
Aug 22, 2022
3e534a2
Update docker-java-api/src/main/java/com/github/dockerjava/api/model/…
ziminghua Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docker-java-api/src/main/java/com/github/dockerjava/api/model/ContainerSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,14 @@ public class ContainerSpec extends DockerObject implements Serializable {
@JsonProperty("Configs")
private List<ContainerSpecConfig> configs;

/**
* @since 1.38
* Run an init inside the container that forwards signals and reaps processes.
* This field is omitted if empty, and the default (as configured on the daemon) is used.
*/
@JsonProperty("Init")
private Boolean init;

/**
* @see #image
*/
Expand Down Expand Up @@ -435,4 +443,13 @@ public ContainerSpec withConfigs(List<ContainerSpecConfig> configs) {
this.configs = configs;
return this;
}

public Boolean getInit() {
return init;
}

public ContainerSpec withInit(Boolean init) {
this.init = init;
return this;
}
}
2 changes: 1 addition & 1 deletion docker-java/src/test/java/com/github/dockerjava/cmd/swarm/UpdateSwarmServiceIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public void testUpdateServiceReplicate() throws Exception {
String networkId = dockerClient.createNetworkCmd().withName("networkname").withDriver("overlay")
.withIpam(new Network.Ipam().withDriver("default")).exec().getId();
TaskSpec taskSpec = new TaskSpec().withContainerSpec(
new ContainerSpec().withImage("busybox").withArgs(Arrays.asList("sleep", "3600")));
new ContainerSpec().withImage("busybox").withArgs(Arrays.asList("sleep", "3600")).withInit(true));
ServiceSpec serviceSpec = new ServiceSpec()
.withMode(new ServiceModeConfig().withReplicated(new ServiceReplicatedModeOptions().withReplicas(1)))
.withTaskTemplate(taskSpec)
Expand Down