Skip to content

Workaround the problem with attachContainerWithTTY test failure (#1492) #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tejksat wants to merge 1 commit into from
Closed

Workaround the problem with attachContainerWithTTY test failure (#1492) #1493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docker-java/src/test/java/com/github/dockerjava/cmd/AttachContainerCmdIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ public void onNext(Frame frame) {
.withFollowStream(true)
.exec(callback);

// The delay above is the workaround for #1492 issue for this test executed on Jersey or HttpClient5 transport implementations.
// Without the delay HTTP requests are sometimes performed in the reverse order ('start' and then 'attach').
// This results in the lost data from stdout and stderr streams of the container process and leads to the test failure.
Thread.sleep(5000L);

dockerClient.startContainerCmd(container.getId()).exec();

callback.awaitCompletion(15, TimeUnit.SECONDS);
Expand Down