Increase the probability for requests to Docker daemon to be executed consequently#1491
Closed
tejksat wants to merge 1 commit intodocker-java:masterfrom
Conversation
tejksat
force-pushed
the
alexander.koshevoy/increaseProbabilityForRequestsToBeExecutedConsecutively
branch
from
93ba44d to
71d7d43
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several
get(...)andpost(...)methods ofcom.github.dockerjava.core.DefaultInvocationBuilderclass (wherecom.github.dockerjava.api.async.ResultCallbackargument is passed) callexecuteAndStream(...)method. This method starts the separate thread which actually performs HTTP request. This method does not wait until the thread is started. This leads to the race condition where several consequent requests could be mixed up in the timeline.F.e. in
com.github.dockerjava.cmd.AttachContainerCmdIT.attachContainerWithTTY()test there are two commands that is performed consequently: "attach to container" and "start container". Sometimes HTTP requests are performed in the reverse order (start and then attach). This results in the lost data from stdout and stderr streams of the container process and leads to the test failure.