Before accepted, this change could use some tests :)

Sure! But I'm not seeing a 'src/test' folder in either of the projects that I made changes to. So I'm not really sure where tests for these projects supposed to live.

So please provide some guidance. E.g. where should I place a test, and how do you run them typically (so I can give em trial run before committing / pushing).

Thanks for your help!

@kdvolder all legacy tests are in docker-java/src/test/main but it would be better to put this one into module's test sources. Please let me know if you feel that you need help with that - I can take over the PR and assist you

For the time being I'm making small commits for addressing individual comments. Once the PR is 'acceptable' and ready to merge I can rebase and squash into a single commit... or not... depending on what you prefer.

I'm looking at adding a test or two but I'm not really sure how to do it, or even what kind of test to add.

I think it would make sense to add a basic test that checks that:

• if you create a zerodep/appache http client instance with a custom 'ConnectionPoolConfig'
• then you get a client that has the expected connection pool manager setup (i.e a org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.PoolingHttpClientConnectionManager instance with the right characteristics.

Problem that I am having is that the apis are not really letting me access internal details such as PoolingHttpClientConnectionManager. So the test can't get access to this instance to check it is setup as expected.

I could try adding more methods to the api so as to expose more of the internals. But probably you wouldn't like it, because the feel I get from the api is that it is deliberately trying to not expose this sort of information.

So if you'd like me write some tests, which I'm happy to do, I'm going to need some concrete suggestions on what exactly to do.

Not sure if guiding me through this may actually be more work for you then writing a simple test case yourself.

I'd be happy for your guidance but if you rather take it from here and write the test yourself, I'm fine with that as well. Whatever is more convenient to you.

@bsideup I think I have addressed all comments except for adding tests.

I don't know what to do about the tests and will leave that in your capable hands as you have so kindly offered:

Please let me know if you feel that you need help with that - I can take over the PR and assist you

In the mean time I have already built jars for our use from the forked repo, and we have adopted the use of those jars for the time being. As far as I am concerned that resolves the issue on our end. Though I would really prefer if this could be merged into master so we do not depend on a custom forked build. If you want me to add tests, I am happy to do so, but I can't do it without your help.

Squashed into a single commit

@kdvolder I just merged your PR into a branch and will take it from there. Thanks for working on it 👍

@bsideup Thanks for taking care of the test case and final polishes.