Skip to content

Make Ulimit use Long to hold soft/hard values exceeding Integer bounds #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bsideup merged 1 commit into from
Feb 14, 2020
Merged

Make Ulimit use Long to hold soft/hard values exceeding Integer bounds #1302

bsideup merged 1 commit into from
Feb 14, 2020

Conversation

@lhotari
Copy link
Contributor

@lhotari lhotari commented Jan 8, 2020 •
edited by marcuslinke
Loading

  • core ulimits can exceed integer bounds
  • preserve binary compatibility of Ulimit class so that API doesn't break
  • preserve JSON serdes of Ulimit class
  • fixes ULimit support LONG #1088

This change is Reviewable

@lhotari lhotari mentioned this pull request Jan 8, 2020
Closed
@bsideup bsideup added this to the 3.2.0 milestone Feb 14, 2020
@lhotari
Make Ulimit use Long to hold soft/hard values exceeding Integer bounds
e93d16d 
- core ulimits can exceed integer bounds
- preserve binary compatibility of Ulimit class so that API doesn't break
- preserve JSON serdes of Ulimit class
- fixes docker-java#1088
@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #1302 into master will increase coverage by 34.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1302      +/-   ##
==========================================
+ Coverage   59.34%   93.75%   +34.4%     
==========================================
  Files         441        1     -440     
  Lines        8692       16    -8676     
  Branches      528        0     -528     
==========================================
- Hits         5158       15    -5143     
+ Misses       3246        1    -3245     
+ Partials      288        0     -288
Impacted Files Coverage Δ
.../dockerjava/api/model/ContainerSpecPrivileges.java
...ockerjava/core/command/RemoveSwarmNodeCmdImpl.java
...ithub/dockerjava/netty/NettyInvocationBuilder.java
...va/com/github/dockerjava/core/GoLangFileMatch.java
...a/com/github/dockerjava/api/model/BindOptions.java
.../github/dockerjava/api/model/PullResponseItem.java
...om/github/dockerjava/core/command/PingCmdImpl.java
...ub/dockerjava/core/command/CreateImageCmdImpl.java
.../github/dockerjava/jaxrs/KillContainerCmdExec.java
.../dockerjava/api/command/CreateNetworkResponse.java
... and 432 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffec4f5...e93d16d. Read the comment docs.

@bsideup bsideup merged commit 33ebafb into docker-java:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsideup bsideup bsideup approved these changes

Assignees

No one assigned

Labels

type/bug

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

ULimit support LONG

3 participants

@lhotari @codecov-io @bsideup