Update httpclient to version 4.5.11#1234
Merged
bsideup merged 2 commits intodocker-java:masterfrom Feb 18, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 56.69% 56.69%
=======================================
Files 467 467
Lines 9026 9026
Branches 535 535
=======================================
Hits 5117 5117
Misses 3631 3631
Partials 278 278Continue to review full report at Codecov.
|
bsideup
changed the title
Member
|
Resolved the conflict, will merge after the tests pass |
bsideup
approved these changes
Feb 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Httpclient 4.5.7 introduced a change to URL rewriting that broke AWS's Java SDK, prompting them to require versions >= 4.5.8 (see aws/aws-sdk-java#1919). Using this library in conjuncture with the AWS SDK (for example to interface with ECS) results in problems unless its httpclient is manually excluded. Upgrading to 4.5.9 does not seem to cause issues with docker-java. The unit tests all pass, and while the integration tests fail they seem to be failing on the upstream head already.
This change is