Use JUnit TemporaryFolder rule in CompressArchiveUtilTest#1210
Merged
KostyaSha merged 1 commit intodocker-java:masterfrom Jul 5, 2019
Merged
Use JUnit TemporaryFolder rule in CompressArchiveUtilTest#1210KostyaSha merged 1 commit intodocker-java:masterfrom
KostyaSha merged 1 commit intodocker-java:masterfrom
Conversation
Instead of delete files created by the test, make use of JUnit TemporaryFolder rule which does exatly that. Not only it simplify the code but also fixes the issue that files where not delete when test was failing.
Contributor
Author
|
The tests failing in CI are not related to my change. It looks like the CI environment have left overs from previous test execution causing the failures |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of delete files created by the test, make use of JUnit
TemporaryFolder rule which does exatly that. Not only it simplify the
code but also fixes the issue that files where not delete when test was
failing.
This change is