Codecov Report

Merging #1209 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1209      +/-   ##
=========================================
- Coverage   58.21%   58.2%   -0.02%     
=========================================
  Files         455     455              
  Lines        8877    8877              
  Branches      534     534              
=========================================
- Hits         5168    5167       -1     
- Misses       3430    3431       +1     
  Partials      279     279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bdabc1...8842fce. Read the comment docs.

Is there something wrong with the tests in CI? I just ran the failing test locally and it passed.

I amended my commit to re-execute the test in CI, let's see how it goes.

ignore 2 errors, btw in future it would be good to remove guava dep at all.

btw in future it would be good to remove guava dep at all.

Ack, I checked quickly and removing Guava will take some effort as it is used in 120 places. Why do you want to remove dependency on Guava?

In the meantime can we get this change in?

Why do you want to remove dependency on Guava?

causes a lot of pain because of binary compatibility, must mask in pure jenkins classloader and some other projects.
AFAIR the only useful thing from guava is some json/parameter encoding that doesn't exist in apache-commons.