Unwrap JSON messages in ResponseStatusExceptionFilter#1180
Merged
KostyaSha merged 3 commits intodocker-java:masterfrom Jun 25, 2019
sschuberth:json-message
Merged
Unwrap JSON messages in ResponseStatusExceptionFilter#1180KostyaSha merged 3 commits intodocker-java:masterfrom sschuberth:json-message
KostyaSha merged 3 commits intodocker-java:masterfrom
sschuberth:json-message
Conversation
IOException is never thrown in getBodyAsMessage().
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 58.59% 58.57% -0.02%
==========================================
Files 455 455
Lines 8815 8821 +6
Branches 532 534 +2
==========================================
+ Hits 5165 5167 +2
- Misses 3371 3374 +3
- Partials 279 280 +1
Continue to review full report at Codecov.
|
For JSON messages like
{"message":"Cannot locate specified Dockerfile: /path/to/Dockerfile"}
unwrap the message to make the exception message read nicer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
This change is