Skip to content

Conversation

@silvestre
Copy link
Contributor

@silvestre silvestre commented Jun 12, 2018

The DiskQuota field in HostConfig first appears in the Docker API v1.25
but is not explicitely listed as API change in
https://docs.docker.com/engine/api/version-history/#v125-api-changes


This change is Reviewable

@KostyaSha
Copy link
Member

the same as #1050 (comment)

The DiskQuota field in HostConfig first appears in the Docker API v1.25
but is not explicitely listed as API change in
https://docs.docker.com/engine/api/version-history/#v125-api-changes
@codecov-io
Copy link

Codecov Report

Merging #1052 into master will decrease coverage by 0.04%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1052      +/-   ##
=========================================
- Coverage   58.75%   58.7%   -0.05%     
=========================================
  Files         441     441              
  Lines        8694    8699       +5     
  Branches      528     528              
=========================================
- Hits         5108    5107       -1     
- Misses       3296    3301       +5     
- Partials      290     291       +1
Impacted Files Coverage Δ
...ockerjava/core/command/CreateContainerCmdImpl.java 52.64% <0%> (-0.55%) ⬇️
...va/com/github/dockerjava/api/model/HostConfig.java 59.45% <33.33%> (ø) ⬆️
...ava/netty/handler/FramedResponseStreamHandler.java 81.03% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4647d...3b4867e. Read the comment docs.

@silvestre
Copy link
Contributor Author

Done.

@KostyaSha KostyaSha merged commit 6f497c9 into docker-java:master Jun 13, 2018
@KostyaSha KostyaSha added this to the 3.1.0-rc-4 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants