Skip to content

DockerCmdExecFactoryImpl change uri inside DockerClientConfig during init ... #456

@mbaechler

Description

@mbaechler

and this breaks support for unix socket.

The problem is that once you called DockerCmdExecFactoryImpl.init() once with a configuration containing uri : unix:///var/run/docker.sock , you can't reuse the configuration for a second DockerCmdExecFactoryImpl instance, because the new value set into DockerClientConfig is not supported but init() method.

The obvious fix is to prevent configuration from being modified.

I'll propose a PR soon.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions