Merge pull request #1207 from tobiasstadler/master

KostyaSha · web-flow · commit f6a2d4976702 · 2019-07-08T03:11:19.000+03:00
Relax email requirement in auth config
diff --git a/src/main/java/com/github/dockerjava/core/DefaultDockerClientConfig.java b/src/main/java/com/github/dockerjava/core/DefaultDockerClientConfig.java
@@ -252,8 +252,7 @@ public DockerConfigFile getDockerConfig() {
 
     private AuthConfig getAuthConfig() {
         AuthConfig authConfig = null;
-        if (getRegistryUsername() != null && getRegistryPassword() != null && getRegistryEmail() != null
-                && getRegistryUrl() != null) {
+        if (getRegistryUsername() != null && getRegistryPassword() != null && getRegistryUrl() != null) {
             authConfig = new AuthConfig()
                     .withUsername(getRegistryUsername())
                     .withPassword(getRegistryPassword())
diff --git a/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java b/src/test/java/com/github/dockerjava/cmd/PullImageCmdIT.java
@@ -111,6 +111,20 @@ public void testPullImageWithValidAuth() throws Exception {
                 .awaitCompletion(30, TimeUnit.SECONDS);
     }
 
+    @Test
+    public void testPullImageWithValidAuthAndEmail() throws Exception {
+        AuthConfig authConfig = RegistryUtils.runPrivateRegistry(dockerRule.getClient())
+                .withEmail("foo@bar.de");
+
+        String imgName = RegistryUtils.createPrivateImage(dockerRule, "pull-image-with-valid-auth");
+
+        // stream needs to be fully read in order to close the underlying connection
+        dockerRule.getClient().pullImageCmd(imgName)
+                .withAuthConfig(authConfig)
+                .exec(new PullImageResultCallback())
+                .awaitCompletion(30, TimeUnit.SECONDS);
+    }
+
     @Test
     public void testPullImageWithNoAuth() throws Exception {
         RegistryUtils.runPrivateRegistry(dockerRule.getClient());
@@ -130,6 +144,7 @@ public void testPullImageWithNoAuth() throws Exception {
                 .awaitCompletion(30, TimeUnit.SECONDS);
     }
 
+
     @Test
     public void testPullImageWithInvalidAuth() throws Exception {
         AuthConfig validAuthConfig = RegistryUtils.runPrivateRegistry(dockerRule.getClient());
diff --git a/src/test/java/com/github/dockerjava/utils/RegistryUtils.java b/src/test/java/com/github/dockerjava/utils/RegistryUtils.java
@@ -81,7 +81,6 @@ public static synchronized AuthConfig runPrivateRegistry(DockerClient dockerClie
             privateRegistryAuthConfig = new AuthConfig()
                     .withUsername("testuser")
                     .withPassword("testpassword")
-                    .withEmail("foo@bar.de")
                     .withRegistryAddress("localhost:" + port);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,6 @@ public static synchronized AuthConfig runPrivateRegistry(DockerClient dockerClie`
`81`	`81`	`privateRegistryAuthConfig = new AuthConfig()`
`82`	`82`	`.withUsername("testuser")`
`83`	`83`	`.withPassword("testpassword")`
`84`		`- .withEmail("foo@bar.de")`
`85`	`84`	`.withRegistryAddress("localhost:" + port);`
`86`	`85`	`}`
`87`	`86`