clean tmp file after upload

fengxx · fengxx · commit e1004d5ba4a8 · 2017-05-23T23:13:29.000+08:00
diff --git a/src/main/java/com/github/dockerjava/core/command/CopyArchiveToContainerCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/CopyArchiveToContainerCmdImpl.java
@@ -112,12 +112,6 @@ public String toString() {
                 .append(remotePath).toString();
     }
 
-    private InputStream buildUploadStream(String hostResource, boolean dirChildrenOnly) throws IOException {
-        Path toUpload = Files.createTempFile("docker-java", ".tar.gz");
-        CompressArchiveUtil.tar(Paths.get(hostResource), toUpload, true, dirChildrenOnly);
-        return Files.newInputStream(toUpload);
-    }
-
     /**
      * @throws com.github.dockerjava.api.exception.NotFoundException
      *             No such container
@@ -131,11 +125,20 @@ public Void exec() throws NotFoundException {
                         "Only one of host resource or tar input stream should be defined to perform the copy, not both");
             }
             // We compress the given path, call exec so that the stream is consumed and then close it our self
-            try (InputStream uploadStream = buildUploadStream(this.hostResource, this.dirChildrenOnly)) {
+            Path toUpload;
+            try {
+                toUpload = Files.createTempFile("docker-java", ".tar.gz");
+                CompressArchiveUtil.tar(Paths.get(hostResource), toUpload, true, dirChildrenOnly);
+            } catch (IOException createFileIOException) {
+                throw new DockerClientException("Unable to perform tar on host resource " + this.hostResource, createFileIOException);
+            }
+            try (InputStream uploadStream = Files.newInputStream(toUpload)) {
                 this.tarInputStream = uploadStream;
                 return super.exec();
             } catch (IOException e) {
-                throw new DockerClientException("Unable to perform tar on host resource " + this.hostResource, e);
+                throw new DockerClientException("Unable to read temp file " + toUpload.toFile().getAbsolutePath(), e);
+            } finally {
+                toUpload.toFile().delete();
             }
         } else if (this.tarInputStream == null) {
             throw new DockerClientException(
