Fix "docker-java-stream" thread stuck at UnixDomainSocket.recv() (#1476)

tejksat · bsideup · web-flow · commit d85ea79eaf7b · 2020-11-16T16:59:04.000+01:00
* Fix "docker-java-stream" thread stuck at UnixDomainSocket.recv() (OkHttp transport) (#1475) Prevent unnecessary recurring calls of `recv()` on UNIX socket, which sometimes results in blocking read and causes hanging of "docker-java-stream" thread. * Fix potential stuck at UnixDomainSocket.read() (HttpClient transport) (#1475) Prevent unnecessary recurring calls of `read()` on UNIX socket, which may result in blocking read and cause hanging of "docker-java-stream" thread. * Use data's length value instead of calculating length once again * Let UnixSocketInputStream.read(..) return -1 when the socket is disconnected or EOF is reached * Move isConnected() check to the beginning of read(..) method * Make UnixSocketInputStream.read() return -1 if EOF has been reached Co-authored-by: Alexander Koshevoy <Alexander.Koshevoy@jetbrains.com> Co-authored-by: Sergei Egorov <bsideup@gmail.com>
diff --git a/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/UnixDomainSocket.java b/docker-java-transport-httpclient5/src/main/java/com/github/dockerjava/httpclient5/UnixDomainSocket.java
@@ -229,30 +229,19 @@ class UnixSocketInputStream extends InputStream {
 
         @Override
         public int read(byte[] bytesEntry, int off, int len) throws IOException {
+            if (!isConnected()) {
+                return -1;
+            }
             try {
                 if (off > 0) {
-                    int bytes = 0;
-                    int remainingLength = len;
-                    int size;
                     byte[] data = new byte[(len < 10240) ? len : 10240];
-                    do {
-                        if (!isConnected()) {
-                            return -1;
-                        }
-                        size = UnixDomainSocket.read(fd, data, (remainingLength < 10240) ? remainingLength : 10240);
-                        if (size <= 0) {
-                            return -1;
-                        }
-                        System.arraycopy(data, 0, bytesEntry, off, size);
-                        bytes += size;
-                        off += size;
-                        remainingLength -= size;
-                    } while ((remainingLength > 0) && (size > 0));
-                    return bytes;
-                } else {
-                    if (!isConnected()) {
+                    int size = UnixDomainSocket.read(fd, data, data.length);
+                    if (size <= 0) {
                         return -1;
                     }
+                    System.arraycopy(data, 0, bytesEntry, off, size);
+                    return size;
+                } else {
                     int size = UnixDomainSocket.read(fd, bytesEntry, len);
                     if (size <= 0) {
                         return -1;
@@ -268,7 +257,7 @@ public int read(byte[] bytesEntry, int off, int len) throws IOException {
         public int read() throws IOException {
             byte[] bytes = new byte[1];
             int bytesRead = read(bytes);
-            if (bytesRead == 0) {
+            if (bytesRead <= 0) {
                 return -1;
             }
             return bytes[0] & 0xff;
diff --git a/docker-java-transport-okhttp/src/main/java/com/github/dockerjava/okhttp/UnixDomainSocket.java b/docker-java-transport-okhttp/src/main/java/com/github/dockerjava/okhttp/UnixDomainSocket.java
@@ -230,24 +230,24 @@ class UnixSocketInputStream extends InputStream {
 
         @Override
         public int read(byte[] bytesEntry, int off, int len) throws IOException {
+            if (!isConnected()) {
+                return -1;
+            }
             try {
                 if (off > 0) {
-                    int bytes = 0;
-                    int remainingLength = len;
-                    int size;
                     byte[] data = new byte[(len < 10240) ? len : 10240];
-                    do {
-                        size = recv(fd, data, (remainingLength < 10240) ? remainingLength : 10240, 0);
-                        if (size > 0) {
-                            System.arraycopy(data, 0, bytesEntry, off, size);
-                            bytes += size;
-                            off += size;
-                            remainingLength -= size;
-                        }
-                    } while ((remainingLength > 0) && (size > 0));
-                    return bytes;
+                    int size = recv(fd, data, data.length, 0);
+                    if (size <= 0) {
+                        return -1;
+                    }
+                    System.arraycopy(data, 0, bytesEntry, off, size);
+                    return size;
                 } else {
-                    return recv(fd, bytesEntry, len, 0);
+                    int size = recv(fd, bytesEntry, len, 0);
+                    if (size <= 0) {
+                        return -1;
+                    }
+                    return size;
                 }
             } catch (LastErrorException lee) {
                 throw new IOException("native read() failed : " + formatError(lee));
@@ -258,14 +258,17 @@ public int read(byte[] bytesEntry, int off, int len) throws IOException {
         public int read() throws IOException {
             byte[] bytes = new byte[1];
             int bytesRead = read(bytes);
-            if (bytesRead == 0) {
+            if (bytesRead <= 0) {
                 return -1;
             }
             return bytes[0] & 0xff;
         }
 
         @Override
         public int read(byte[] bytes) throws IOException {
+            if (!isConnected()) {
+                return -1;
+            }
             return read(bytes, 0, bytes.length);
         }
     }
