Skip to content

Commit b04832d

Browse files
committed
restore value ffor tests
1 parent ae312bc commit b04832d

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

docker-java-core/src/main/java/com/github/dockerjava/core/InvocationBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private void onResult(A_RES_T object) {
6969
}
7070

7171
@Override
72-
public void close() throws IOException {
72+
public void close() throws IOException {
7373
try {
7474
super.close();
7575
} finally {

docker-java/src/test/java/com/github/dockerjava/cmd/CmdIT.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ public DockerCmdExecFactory createExecFactory() {
3535
OKHTTP(true) {
3636
@Override
3737
public DockerCmdExecFactory createExecFactory() {
38-
return new OkHttpDockerCmdExecFactory().withConnectTimeout(30 * 1000);
38+
return new OkHttpDockerCmdExecFactory()
39+
.withConnectTimeout(60 * 1000)
40+
.withReadTimeout(0);
3941
}
4042
};
4143

docker-java/src/test/java/com/github/dockerjava/cmd/StatsCmdIT.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package com.github.dockerjava.cmd;
22

3+
import com.github.dockerjava.api.async.ResultCallbackTemplate;
34
import com.github.dockerjava.api.command.CreateContainerResponse;
45
import com.github.dockerjava.api.model.Statistics;
5-
import com.github.dockerjava.core.async.ResultCallbackTemplate;
66
import org.junit.Test;
77
import org.slf4j.Logger;
88
import org.slf4j.LoggerFactory;
@@ -28,8 +28,10 @@ public void testStatsStreaming() throws InterruptedException, IOException {
2828
dockerRule.getClient().startContainerCmd(container.getId()).exec();
2929

3030
boolean gotStats = false;
31-
try (StatsCallbackTest statsCallback = dockerRule.getClient().statsCmd(container.getId()).exec(
32-
new StatsCallbackTest(countDownLatch))) {
31+
try (StatsCallbackTest statsCallback = dockerRule.getClient()
32+
.statsCmd(container.getId())
33+
.exec(new StatsCallbackTest(countDownLatch))) {
34+
3335
assertTrue(countDownLatch.await(10, TimeUnit.SECONDS));
3436
gotStats = statsCallback.gotStats();
3537

@@ -53,7 +55,7 @@ public void testStatsNoStreaming() throws InterruptedException, IOException {
5355
dockerRule.getClient().startContainerCmd(container.getId()).exec();
5456

5557
try (StatsCallbackTest statsCallback = dockerRule.getClient().statsCmd(container.getId()).withNoStream(true).exec(
56-
new StatsCallbackTest(countDownLatch))) {
58+
new StatsCallbackTest(countDownLatch))) {
5759
countDownLatch.await(5, TimeUnit.SECONDS);
5860

5961
LOG.info("Stop stats collection");
@@ -67,7 +69,7 @@ public void testStatsNoStreaming() throws InterruptedException, IOException {
6769
assertEquals("Expected stats called only once", countDownLatch.getCount(), NUM_STATS - 1);
6870
}
6971

70-
private class StatsCallbackTest extends ResultCallbackTemplate<StatsCallbackTest, Statistics> {
72+
private static class StatsCallbackTest extends ResultCallbackTemplate<StatsCallbackTest, Statistics> {
7173
private final CountDownLatch countDownLatch;
7274

7375
private Boolean gotStats = false;

0 commit comments

Comments
 (0)